Remove stale elements before cache #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dig this. Can you add a test? |
Added tests: Let me know if something's still missing. |
packagethief
added a commit
that referenced
this pull request
Feb 14, 2023
Renames the `[data-turbo-cache=false]` attribute (used to denote temporary elements that should be removed before caching) to `[data-turbo-temporary]` for better similarity with `[data-turbo-permanent]`, its conceptual opposite. This is a superficial change, but worth it in terms of cohesion, I think. The pairing of "temporary" with "permanent" is just too good to ignore. Also, given the existence of `turbo-cache-*` as the namespace for page-level cache control, a unique name is less likely to confuse. References: - #238
packagethief
added a commit
that referenced
this pull request
Feb 14, 2023
Renames the `[data-turbo-cache=false]` attribute (used to denote temporary elements that should be removed before caching) to `[data-turbo-temporary]` for better similarity with `[data-turbo-permanent]`, its conceptual opposite. This is a superficial change, but worth it in terms of cohesion, I think. The pairing of "temporary" with "permanent" is just too good to ignore. Also, given the existence of `turbo-cache-*` as the namespace for page-level cache control, a unique name is less likely to confuse. References: - #238
dhh
pushed a commit
that referenced
this pull request
Feb 15, 2023
…#871) Renames the `[data-turbo-cache=false]` attribute (used to denote temporary elements that should be removed before caching) to `[data-turbo-temporary]` for better similarity with `[data-turbo-permanent]`, its conceptual opposite. This is a superficial change, but worth it in terms of cohesion, I think. The pairing of "temporary" with "permanent" is just too good to ignore. Also, given the existence of `turbo-cache-*` as the namespace for page-level cache control, a unique name is less likely to confuse. References: - #238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some content is inherently stale the moment you've shown it to users. Eg in Ruby on Rails it's common that you use flash messages to communicate a message from your controller to your users.
When a user navigates away and returns to the original page, turbo will briefly show cached content:
Screen.Recording.2021-02-09.at.12.35.57.mov
This PR adds a hook by adding
data-turbo-cache="false"to individual dom elements to remove them from Turbo's cache.--
Originally posted about the issue in hotwired/turbo-rails#117