Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comment on namespaced classes #263

Closed
gylaz opened this issue May 13, 2014 · 2 comments
Closed

Incorrect comment on namespaced classes #263

gylaz opened this issue May 13, 2014 · 2 comments
Labels
bug

Comments

@gylaz
Copy link
Member

gylaz commented May 13, 2014

https://github.com/thoughtbot/oneblock/pull/38#discussion_r12610426

screen shot 2014-05-13 at 2 48 43 pm
@bbatsov
Copy link

bbatsov commented May 21, 2014

Looks like a RuboCop bug.

My bad. By default the expected style for code like this is:

module Api
  module V1
    class ...
  ...

You'll have to adjust the enforced style or disable the cop.

@salbertson salbertson added the bug label Jul 1, 2014
@salbertson
Copy link
Member

#292

@salbertson salbertson mentioned this issue Jul 10, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbatsov @gylaz @salbertson