[botbuilder-adapter-web] TypeError: cb is not a function

[dominik1001]

Are you sure this is an issue with the Botkit core module?

Yes (botbuilder-adapter-web)

What are you trying to achieve or the steps to reproduce?

Keeping a WebSocket running.

What was the result you received?

The above error, with the following stack trace:

TypeError: cb is not a function
1
at sendAfterClose (/app/packages/api/node_modules/ws/lib/websocket.js line 733 col 4)
cb(err);
2
at WebSocket.ping (/app/packages/api/node_modules/ws/lib/websocket.js line 273 col 6)
sendAfterClose(this, data, cb);
3
at each (/app/packages/api/node_modules/botbuilder-adapter-web/lib/web_adapter.js line 144 col 19)
ws.ping('', false, true);
4
at Set.forEach (<anonymous> line (unknown))
5
at Timeout._onTimeout (/app/packages/api/node_modules/botbuilder-adapter-web/lib/web_adapter.js line 139 col 29)
this.wss.clients.forEach(function each(ws) {
6
at listOnTimeout (internal/timers.js line 549 col 16)
7
at processTimers (internal/timers.js line 492 col 6)

botkit/packages/botbuilder-adapter-web/src/web_adapter.ts

Line 160 in 848712b

ws.ping('', false, true);

https://github.com/websockets/ws/blob/da42ea17451f11eed54adb54d3beeedbb1c2aa70/lib/websocket.js#L270

https://github.com/websockets/ws/blob/da42ea17451f11eed54adb54d3beeedbb1c2aa70/lib/websocket.js#L730

What did you expect?

No Error

Screenshots and animated GIFs

Context:

• Botkit version: 4.9.0
• Messaging Platform: Web
• Node version: v12.18.2
• Os: Ubuntu 18.04.4 LTS
• Any other relevant information:

Analysis

IMO the call

ws.ping('', false, true);

is faulty since the third argument should be a function.

[benbrown]

This will be fixed in the next release. Thanks for helping! Sorry for the long wait.