-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.10 WIP #2022
Version 4.10 WIP #2022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great exposing the TeamsInfo api, however is there a reason why you don’t update bot.updateMessage to work for teams this way such as https://botkit.ai/docs/v4/reference/slack.html#updatemessage
(I am going to have to double check this method now in teams as I didn’t think it worked before)
Similarly the slack adapter exposed:
startConversationInChannel()
startConversationInThread()
startPrivateConversation()
Which all make it easy to integrate with, and would make it consistent across platforms.
@Danjuro good question! I don't have a great answer. My initially reasoning is that the Bot Framework adapter can be used for other platforms in addition to Teams, and they may not support those methods. That said, I'll see what I can do! |
fixes #1984
fixes #1961
fixes #2003