Handle block_actions FIXES #1595 #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benbrown
reviewed
Feb 22, 2019
lib/SlackBot.js
Outdated
|
|
||
| if (message.type == 'block_actions') { | ||
| message.text = message.actions[0].value; | ||
| message.type = 'block_actions_callback'; |
There was a problem hiding this comment.
I think we should just leave the type as is -- less to understand!
|
@makstaks Thanks for the contribution. We should add a section about handling this new event in the docs. Would you be willing to do that as well? The docs are in a separate repo |
|
@benbrown updated docs (howdyai/botkit-docs#30) and made suggested code fix. I didn't have time to come up with more detailed examples using blocks, I will do so next week. Hopefully, the docs are adequate for now. Thanks. |
benbrown
approved these changes
Feb 25, 2019
benbrown
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.