Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .ts (or parameterized) file extensions for loadModules #1777

Merged
merged 8 commits into from
Oct 28, 2019
Merged

Support .ts (or parameterized) file extensions for loadModules #1777

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9c762a1
Support .ts file extensions for loadModules
O-Mutt Aug 21, 2019
daca66d
Update packages/botkit/src/core.ts
O-Mutt Aug 29, 2019
c478d91
Merge branch 'master' into master
O-Mutt Sep 3, 2019
46371de
Update packages/botkit/src/core.ts
O-Mutt Sep 3, 2019
ae91296
Merge branch 'master' into master
O-Mutt Sep 10, 2019
41da022
Merge branch 'master' into master
O-Mutt Sep 18, 2019
59c7ac1
Merge branch 'master' into master
benbrown Oct 28, 2019
9c477fc
Merge branch 'master' into master
benbrown Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/botkit/src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,10 +1123,13 @@ export class Botkit {
* ```
*
* @param p {string} path to a folder of module files
* @param exts {string[]} the extensions that you would like to load (default: ['.js', '.ts'])
O-Mutt marked this conversation as resolved.
Show resolved Hide resolved
*/
public loadModules(p: string): void {
// load all the .js files from this path
fs.readdirSync(p).filter((f) => { return (path.extname(f) === '.js'); }).forEach((file) => {
public loadModules(p: string, exts: string[] = ['.js', '.ts']): void {
O-Mutt marked this conversation as resolved.
Show resolved Hide resolved
// load all the .js|.ts files from this path
fs.readdirSync(p).filter((f) => {
return exts.includes(path.extname(f));
}).forEach((file) => {
this.loadModule(path.join(p, file));
});
}
Expand Down