This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Support .ts (or parameterized) file extensions for loadModules #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
O-Mutt
changed the title
Support .ts file extensions for loadModules
Support .ts (or parameterized) file extensions for loadModules
Aug 21, 2019
But the code that actually runs is the .js files. You won't ever be executing against the uncompiled ts files. |
That wouldn't exactly be true if you are running |
I've never seen that! |
|
O-Mutt
commented
Aug 29, 2019
O-Mutt
commented
Sep 3, 2019
removing incorrect jsdoc
Yes please ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relatively small change that showed up when I was using typescript for my features in the demo bot.