Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .ts (or parameterized) file extensions for loadModules #1777

Merged
merged 8 commits into from
Oct 28, 2019

Conversation

O-Mutt
Copy link
Contributor

@O-Mutt O-Mutt commented Aug 21, 2019

A relatively small change that showed up when I was using typescript for my features in the demo bot.

@O-Mutt O-Mutt changed the title Support .ts file extensions for loadModules Support .ts (or parameterized) file extensions for loadModules Aug 21, 2019
@benbrown
Copy link
Contributor

But the code that actually runs is the .js files. You won't ever be executing against the uncompiled ts files.

@O-Mutt
Copy link
Contributor Author

O-Mutt commented Aug 21, 2019

That wouldn't exactly be true if you are running ts-node. Yes, all the way down it is javascript but at a base level I wouldn't be checking in .js files therefore it wouldn't pick up my /features/*.ts files

@benbrown
Copy link
Contributor

I've never seen that!

@O-Mutt
Copy link
Contributor Author

O-Mutt commented Aug 22, 2019

ts-node 🔥! Welcome to the FUTURE! :D

packages/botkit/src/core.ts Outdated Show resolved Hide resolved
packages/botkit/src/core.ts Outdated Show resolved Hide resolved
removing incorrect jsdoc
@maximebeaudoin
Copy link

Yes please !

@benbrown benbrown added this to the 4.6 milestone Sep 13, 2019
@benbrown benbrown merged commit a4b54e7 into howdyai:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants