Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Adapter - Prioritize User.id as From.Id #2089

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

mdrichardson
Copy link
Contributor

Parity: microsoft/botbuilder-dotnet#5393

Description

When the user presses a button in slack, the one sending the payload to the bot is the user not the bot.

Specific Changes

  • Swapped the priority of the id to pick to populate activity.from.id

@benbrown benbrown self-requested a review May 3, 2021 17:45
@stale
Copy link

stale bot commented Jul 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 13, 2021
@stale stale bot closed this Jul 21, 2021
@benbrown
Copy link
Contributor

not stale

@benbrown benbrown reopened this Jul 21, 2021
@stale stale bot removed the stale label Jul 21, 2021
@benbrown benbrown merged commit e97724c into howdyai:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants