Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Slack Adapter - Prioritize User.id as From.Id #5393

Merged
merged 1 commit into from
May 1, 2021

Conversation

martinlarosa
Copy link
Contributor

Fixes #5323

Description

When the user presses a button in slack, the one sending the payload to the bot is the user not the bot.

Specific Changes

  • Swapped the priority of the id to pick to populate Activity.From.Id

When the user presses a button in slack,
the one sending the payload to the bot is the user not the bot.
@martinlarosa martinlarosa requested a review from a team as a code owner March 30, 2021 17:48
@mdrichardson mdrichardson changed the title Slack Adapter - Prioritize User.id as From.Id bug: Slack Adapter - Prioritize User.id as From.Id Apr 30, 2021
Copy link
Contributor

@mdrichardson mdrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When receiving a slack payload, the Activity's From.Id is the BotId instead of the user's Id
2 participants