Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin documentation and examples #102

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

abmyii
Copy link
Contributor

@abmyii abmyii commented Feb 24, 2020

Docs, as mentioned in #101.

I must admit that what I wrote was a bit rambling and incoherent and will need improvement and simplifying. I don't think I understand plugins properly! And as Einstein said:

“If you can't explain it to a six year old, you don't understand it yourself.”
(https://www.goodreads.com/quotes/19421-if-you-can-t-explain-it-to-a-six-year-old)

Haha!

I hope what I've written is workable and not totally useless, because it does seem so to me a bit unfortunately!

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c1cc5fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #102   +/-   ##
=========================================
  Coverage          ?   94.64%           
=========================================
  Files             ?       10           
  Lines             ?      635           
  Branches          ?        0           
=========================================
  Hits              ?      601           
  Misses            ?       34           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cc5fc...7814cb6. Read the comment docs.

@howie6879
Copy link
Owner

Thanks for your great job

@howie6879 howie6879 merged commit 74b1fe0 into howie6879:master Feb 25, 2020
@abmyii
Copy link
Contributor Author

abmyii commented Feb 25, 2020

Um, thanks! But don't you think it is too difficult to understand?

@abmyii
Copy link
Contributor Author

abmyii commented Feb 25, 2020

Also, I noticed a little mistake - the last line is:

And you should a `developer.db` should be created.

But should be:

And `developer.db` should have been created.

@howie6879
Copy link
Owner

you can change at any time ~

https://docs.python-ruia.org/en/examples/spider_parent_class.html

@abmyii
Copy link
Contributor Author

abmyii commented Feb 25, 2020

Shall I start a new PR?

@howie6879
Copy link
Owner

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants