Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mpris:artUrl #25

Closed
Vexatos opened this issue Jun 11, 2019 · 4 comments
Closed

Add support for mpris:artUrl #25

Vexatos opened this issue Jun 11, 2019 · 4 comments

Comments

@Vexatos
Copy link

Vexatos commented Jun 11, 2019

Would be nice to have album art displayed by software that supports it. I guess for embedded art, a temp file would have to be created for this to work.

@hoyon
Copy link
Owner

hoyon commented Jun 12, 2019

That would indeed be very nice. I briefly played around with this in the past but since, as far as I can tell, there is no way to access the album art from the mpv api, it is pretty difficult. Although it's possible I've missed it since the docs can be quite cryptic at times.

For embedded artwork I tried manually loading the file using ffmpeg which sort of worked but it didn't seem very robust and I don't really have the time to be delving too deep into ffmpeg.

Perhaps the plugin could look for external album art in the directory of the current file, but I'm not aware if there is any standard or convention for naming album art files. Maybe just the first *.jpg found in the directory?

@Vexatos
Copy link
Author

Vexatos commented Jun 12, 2019

It might be jpg or png, but generally, this might already be a good start. I also checked the docs briefly and couldn't find very much.

@ghost
Copy link

ghost commented Jan 15, 2020

antlarr's lua-mpris plugin for mpv looks for external album art in the directory of the current file: antlarr/lua-mpris@1f2b53f

Perhaps we can refer to VLC for the list of external album art files to look for?

@hoyon hoyon closed this as completed in 83210e7 Jan 15, 2020
@hoyon
Copy link
Owner

hoyon commented Jan 15, 2020

Thanks for the nudge @86423355844265459587182778 , hopefully this works for external images.

I don't plan on ever supporting embedded artwork due to the complexity. That is, unless mpv adds a way to access it (unlikely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants