Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL]: [save_model] function in [ppo.py] is duplicated #3624

Closed
1 task done
ddobokki opened this issue Apr 22, 2023 · 0 comments
Closed
1 task done

[PROPOSAL]: [save_model] function in [ppo.py] is duplicated #3624

ddobokki opened this issue Apr 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ddobokki
Copy link
Contributor

Proposal

ColossalAI/applications/Chat/coati/trainer/ppo.py

Line 210 in d7bf284

def save_model(self, path: str, only_rank0: bool = False, tokenizer: Optional[PreTrainedTokenizerBase] = None) -> None:

ColossalAI/applications/Chat/coati/trainer/ppo.py

Line 213 in d7bf284

def save_model(self, path: str, only_rank0: bool = False, tokenizer: Optional[PreTrainedTokenizerBase] = None) -> None:

Probably a simple mistake, it need to clear one.

Self-service

  • I'd be willing to do some initial work on this proposal myself.
@ddobokki ddobokki added the enhancement New feature or request label Apr 22, 2023
@ddobokki ddobokki mentioned this issue Apr 22, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddobokki