Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-18241 Remove unwanted spinlock in UDP collation #10399

Merged
merged 1 commit into from
Sep 8, 2017
Merged

HPCC-18241 Remove unwanted spinlock in UDP collation #10399

merged 1 commit into from
Sep 8, 2017

Conversation

richardkchapman
Copy link
Member

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

TBD

@richardkchapman richardkchapman changed the title More udp cleanup HPCC-18241 Remove unwanted spinlock in UDP collation Sep 6, 2017
@richardkchapman richardkchapman force-pushed the more-udp-cleanup branch 2 times, most recently from d8c480a to 2c33b0a Compare September 6, 2017 10:34
@richardkchapman
Copy link
Member Author

@ghalliday

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-18241
Jira updated

@ghalliday
Copy link
Member

Should you also delete the streamingSupported boolean and the associated code? Is this something that would be worth adding back at some point?

@richardkchapman
Copy link
Member Author

streamingSupported is not directly related but seems like it is unused (probably has been for some time) so I'll remove at the same time.

Should we add it back in? Possibly but would need a complete rethink about how to do it, and would probably make sense only as part of a migration of udplib to some other protocol or library.

@richardkchapman
Copy link
Member Author

@ghalliday Ready to merge I think. Mark has tested on the FutureRoxie POC.

ghalliday
ghalliday reviewed Sep 8, 2017
View reviewed changes
roxie/udplib/udpmsgpk.cpp Outdated
@@ -539,16 +532,15 @@ class CMessageCollator : implements IMessageCollator, public CInterface
isNew = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: isNew is no longer used.

@richardkchapman
HPCC-18241 Remove unwanted spinlock in UDP collation
14735a5 
Semaphore is not signalled until the value is ready to safely read.

If the value being read was liable to change after it was read, logic
elsewhere would be wrong.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@ghalliday ghalliday merged commit 13549ba into hpcc-systems:candidate-6.4.2 Sep 8, 2017
@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
Sha: 10004f6
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 92.318 seconds

Install hpccsystems-platform-community_6.4.2-rc2.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 96 96 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 733 733 0
test (thor) 627 627 0
test (roxie) 760 760 0

HPCC Stop: OK
HPCC Uninstall: OK

@richardkchapman richardkchapman deleted the more-udp-cleanup branch November 22, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardkchapman @hpcc-jirabot @ghalliday @HPCCSmoketest