HPCC-18936 Allow a timing unit test to be run individually

[ghalliday]

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Testing:

[ghalliday]

@richardkchapman please review

[AttilaVamos]

@ghalliday I saw some problem with toxml.ecl before and put a comment about it here: https://track.hpccsystems.com/browse/HPCC-18918?focusedCommentId=76425&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-76425

[ghalliday]

@richardkchapman I think the failure is unrelated. However it looks like it happened after the ifblock fix was merged, so may still be a problem.

[richardkchapman]

I suspect it's a race condition - I think the ECL both creates and reads that file, and it may be that the codegen cannot spot the dependency. Should raise a Jira to fix it but as you say not related

[richardkchapman]

Not sure I understand why this name change was made

[ghalliday]

The name was changed because the filter for running a unit test matches using a substring. If the 2 is on the end of the test name it is impossible to only run the first test - since it will also run this test!

[richardkchapman]

Hmm. I would have gone for calling them tests1 and tests2 then...

[richardkchapman]

@ghalliday One minor question

[ghalliday]

@richardkchapman

[richardkchapman]

@ghalliday

[ghalliday]

@richardkchapman repushed

[HPCCSmoketest]

Automated Smoketest: ✅
Sha: d77a27b
Build: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	81	81	0	0	0
wutoolTest(Dali)	19	19	0	0	0
wutoolTest(Cassandra)	19	19	0	0	0

Regression test result:

phase	total	pass	fail
setup (hthor)	11	11	0
setup (thor)	11	11	0
setup (roxie)	11	11	0
test (hthor)	737	737	0
test (thor)	648	648	0
test (roxie)	766	766	0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
36 sec (00:00:36)	166 sec (00:02:46)	59 sec (00:00:59)	8 sec (00:00:08)	54 sec (00:00:54)	1078 sec (00:17:58)	39 sec (00:00:39)	1440 sec (00:24:00)