-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-19149 Fix windows build problems #10897
Conversation
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
https://track.hpccsystems.com/browse/HPCC-19149 |
https://track.hpccsystems.com/browse/HPCC-19149 |
@richardkchapman please review |
@@ -176,7 +176,9 @@ elseif ( NOT MAKE_DOCS_ONLY ) | |||
HPCC_ADD_SUBDIRECTORY (services "PLATFORM") | |||
HPCC_ADD_SUBDIRECTORY (thorlcr "PLATFORM") | |||
HPCC_ADD_SUBDIRECTORY (testing) | |||
HPCC_ADD_SUBDIRECTORY (configuration) | |||
if ( NOT WIN32 ) | |||
HPCC_ADD_SUBDIRECTORY (configuration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume config manager is not meant to be supported on windows. If it is, then more work is needed.
@@ -38,6 +38,7 @@ | |||
#include "roxiemem.hpp" | |||
#include "thorstep.hpp" | |||
#include "roxiemem.hpp" | |||
#undef new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The debug new overrides clash with the placement new operator
Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com
Type of change:
Checklist:
Testing: