Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-19778 Declare wselk feature level in configmgr #11240

Merged
merged 1 commit into from
May 31, 2018
Merged

HPCC-19778 Declare wselk feature level in configmgr #11240

merged 1 commit into from
May 31, 2018

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented May 25, 2018 •
edited
Loading

  • Declares new wselkaccess flag in missing locations

Signed-off-by: Rodrigo Pastrana rodrigo.pastrana@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-19778
Jira updated

@rpastrana
Copy link
Member Author

@wangkx change is being verified, but please review the changes.

wangkx
wangkx approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@wangkx wangkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks good.

@rpastrana
Copy link
Member Author

@wangkx caught a slight issue please review latest commit

wangkx
wangkx approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@wangkx wangkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks fine.

@richardkchapman
Copy link
Member

@rpastrana Should this target the beta branch?

@rpastrana
Copy link
Member Author

@richardkchapman yes, please don't merge yet... we're performing system test on 190

@rpastrana rpastrana changed the base branch from master to candidate-7.0.0beta1 May 29, 2018 15:47
@richardkchapman
Copy link
Member

@rpastrana Please let me know when ready to merge

@rpastrana rpastrana force-pushed the HPCC-19778-WSELKLDAP branch 2 times, most recently from ef2d741 to 6f710fb Compare May 30, 2018 18:44
@rpastrana
Copy link
Member Author

Verified on 190, other bugs opened against LDAP and configmanager which kept this issue from working on 190.
@richardkchapman please merge

@rpastrana
HPCC-19778 Declare wselk feature level in configmgr
423c648 
- Declares new wselkaccess flag in missing locations

- Declares Athenticate=YES in stock env.xml

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexis.com>
@rpastrana
Copy link
Member Author

@wangkx I squashed all commits, but please review once more

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 423c648
Build: success
Install hpccsystems-platform-community_7.0.0-beta1rc1.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 88 88 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 786 786 0
test (thor) 717 717 0
test (roxie) 830 830 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
9 sec (00:00:09) 173 sec (00:02:53) 60 sec (00:01:00) 9 sec (00:00:09) 30 sec (00:00:30) 1210 sec (00:20:10) 18 sec (00:00:18) 1509 sec (00:25:09)

@richardkchapman richardkchapman merged commit c14f960 into hpcc-systems:candidate-7.0.0beta1 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkx wangkx wangkx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rpastrana @hpcc-jirabot @richardkchapman @HPCCSmoketest @wangkx