Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-20045 replace Eclipse_Html.xsl with PortalGen.xsl #11475

Merged

Conversation

xwang2713
Copy link
Member

Replace Eclipse_Html.xsl with ProtalGen.xsl in portal HTML generation.
fix dockbool-xsl path in PortalGen.xsl

Signed-off-by: Xiaoming Wang xiaoming.wang@lexisnexi.com

@g-pan please review

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.

Testing:

http://10.240.32.243/view/custom/job/CE-HPCC-20045-Docs-Portal_XSL/

@hpcc-jirabot
Copy link

Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@richardkchapman
Copy link
Member

Typo "ProtalGen" in the commit message @xwang2713

@xwang2713 xwang2713 changed the title HPCC-20045 replace Eclipse_Html.xsl with ProtalGen.xsl HPCC-20045 replace Eclipse_Html.xsl with PortalGen.xsl Jul 31, 2018
@xwang2713 xwang2713 force-pushed the HPCC_20045-PortalGen.xsl branch 2 times, most recently from c62772e to ca777c8 Compare July 31, 2018 20:03
… generation

fix dockbool-xsl path in PortalGen.xsl
@xwang2713
Copy link
Member Author

@g-pan I corrected typo and rebased. Can you double check the bottom of file EclipseHelp.txt.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: ecc4b72
Build: success
Install hpccsystems-platform-community_7.0.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 89 89 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 804 804 0
test (thor) 729 729 0
test (roxie) 878 878 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
22 sec (00:00:22) 356 sec (00:05:56) 113 sec (00:01:53) 9 sec (00:00:09) 30 sec (00:00:30) 1278 sec (00:21:18) 19 sec (00:00:19) 1827 sec (00:30:27)

Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@richardkchapman richardkchapman merged commit 4f5e913 into hpcc-systems:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants