Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-20274 Despray only showing single dropzone #11562

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

miguelvazq
Copy link

@miguelvazq miguelvazq commented Aug 10, 2018

If a landing zone is not configured correctly it would cause other landing zones
not to load due to missing machines in the configuraion.

Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot
Copy link

If a landing zone is not configured correctly it would cause other landing zones
not to load due to missing machines in the configuraion.

Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
@miguelvazq
Copy link
Author

@GordonSmith Please review.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ❌
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 0a0fb23
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 93.685 seconds

Process finished normally
CPack: Create package

Lint error(s):
npm ERR! Test failed. See above for more details.

Install hpccsystems-platform-community_6.4.26-closedown1.el7.x86_64.rpm
Creating group hpcc ...\x1b[32m [ OK ] \x1b[0m
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 97 97 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 736 736 0
test (thor) 631 631 0
test (roxie) 765 765 0

HPCC Stop: OK
HPCC Uninstall: OK

Build error:
Build log Build log

Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
12 sec (00:00:12) 151 sec (00:02:31) 169 sec (00:02:49) 11 sec (00:00:11) 58 sec (00:00:58) 1155 sec (00:19:15) 41 sec (00:00:41) 1597 sec (00:26:37)

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ghalliday ghalliday merged commit b7423af into hpcc-systems:candidate-6.4.26 Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants