Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-17840 Normalize data for stats chart #11649

Merged

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Sep 4, 2018

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot
Copy link

@GordonSmith
Copy link
Member Author

@miguelvazq please review (acutal commit: 9b987ba)

Will need rebase once #11631 is pulled

@GordonSmith
Copy link
Member Author

Resolved errors and rebased, still needs rebase once #11631 is pulled

@richardkchapman
Copy link
Member

@GordonSmith Needs another rebase

@GordonSmith
Copy link
Member Author

I will rebase once #11631 is pulled.

@richardkchapman
Copy link
Member

@GordonSmith It has been pulled

@GordonSmith
Copy link
Member Author

@richardkchapman rebased - can you leave the smoketest re-run before pulling?

@richardkchapman richardkchapman changed the title HPCC-17840 HPCC-17840 Normalize data for stats chart Sep 6, 2018
Allow charting different metrics on a single chart.

Signed-off-by: Gordon Smith <gordonjsmith@gmail.com>
@GordonSmith
Copy link
Member Author

@AttilaVamos Can we re-run the smoke test here?- thx.

@AttilaVamos
Copy link
Contributor

@GordonSmith it is in the queue.

@GordonSmith
Copy link
Member Author

@AttilaVamos Long queue I guess?

@AttilaVamos
Copy link
Contributor

@GordonSmith The #11621 generated huge amount of errors and stacked. Actually your PR is on its way, result is in <15 minutes.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 6ad4ed4
HPCC Uninstall: OK
Build: success
ECL Watch: Rebuilding Site
Install warning(s):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: phantomjs-prebuilt@2.1.16 (node_modules/jshint/node_modules/phantomjs-prebuilt):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: phantomjs-prebuilt@2.1.16 install: node install.js
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

Rebuild: success
Install hpccsystems-platform-community_7.0.0-rc1.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 94 94 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 805 805 0
test (thor) 729 729 0
test (roxie) 878 878 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
105 sec (00:01:45) 176 sec (00:02:56) 170 sec (00:02:50) 21 sec (00:00:21) 43 sec (00:00:43) 1346 sec (00:22:26) 19 sec (00:00:19) 1880 sec (00:31:20)

@richardkchapman richardkchapman merged commit c0cbeca into hpcc-systems:master Sep 7, 2018
@GordonSmith GordonSmith deleted the HPCC-17840-StatsViz branch September 7, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants