Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-20631 Set session id context #11764

Merged
merged 1 commit into from
Sep 28, 2018
Merged

HPCC-20631 Set session id context #11764

merged 1 commit into from
Sep 28, 2018

Conversation

mayx
Copy link
Member

@mayx mayx commented Sep 26, 2018 •
edited
Loading

  • Set the session id context of an ssl context to be "hpccsystems", a
    value unique to our applicaiton.

Signed-off-by: mayx yanrui.ma@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-20631
Jira updated

@mayx
Copy link
Member Author

mayx commented Sep 26, 2018

@mckellyln please review.

mckellyln
mckellyln reviewed Sep 27, 2018
View reviewed changes
system/security/securesocket/securesocket.cpp Outdated
@@ -896,6 +900,9 @@ class CSecureSocketContext : implements ISecureSocketContext, public CInterface
{
throw MakeStringException(-1, "ctx can't be created");
}

setSessionIdContext();
Copy link
Contributor

@mckellyln mckellyln Sep 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setting the ctx session is meaningful only on the server side ?
If that is true, should we do this only for server, ie:

        if(sockettype == ServerSocket)
            setSessionIdContext();

Or do this only before an SSL_accept() ?

@mckellyln
Copy link
Contributor

@mayx a few questions:
1). does it make sense to set on client side ?
2). would it make sense to have different ids for different components or use cases ?
3). what is the point of setting the id, are you planning on adding session re-use/cache support ?

@mayx
Copy link
Member Author

mayx commented Sep 27, 2018

  1. it's only needed on the server side
  2. Not for our use case
  3. The purpose is to fix an error that happens with SSL_accept when client certificate verification is enabled and the client sends in a certificate. Client certificate verification is usually not enabled.

@mckellyln
Copy link
Contributor

@mayx ok, thanks - so should it just be done before SSL_accept() or only if sockettype == ServerSocket ?
Other than that - looks good.

@mayx
Copy link
Member Author

mayx commented Sep 27, 2018

Good point. The man page states it's only "useful" for server side and it doesn't seem to affect client side functioning. But to stay on the safe side, I'll add the check of sockettype.

@mayx
HPCC-20631 Set session id context
4a1f1dc 
- Set the session id context of an ssl context to be "hpccsystems", a
  value unique to our applicaiton.

Signed-off-by: mayx <yanrui.ma@lexisnexisrisk.com>
@mayx
Copy link
Member Author

mayx commented Sep 27, 2018

@mckellyln change uploaded please review again.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 4a1f1dc
Build: success
Install hpccsystems-platform-community_7.0.0-rc2.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 94 94 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 806 806 0
test (thor) 730 730 0
test (roxie) 879 879 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
21 sec (00:00:21) 190 sec (00:03:10) 95 sec (00:01:35) 19 sec (00:00:19) 42 sec (00:00:42) 1670 sec (00:27:50) 18 sec (00:00:18) 2055 sec (00:34:15)

@mckellyln
Copy link
Contributor

@mayx looks good.

mckellyln
mckellyln approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@mckellyln mckellyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayx approved

@richardkchapman richardkchapman merged commit 121d7ee into hpcc-systems:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckellyln mckellyln mckellyln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mayx @hpcc-jirabot @mckellyln @HPCCSmoketest @richardkchapman