-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-20728 Fix some problems with DafilesrvGroup settings #11818
Conversation
Also add logging for Row Service SSL setup. Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
https://track.hpccsystems.com/browse/HPCC-20728 |
@ghalliday - please review |
@@ -397,9 +397,25 @@ int main(int argc,char **argv) | |||
if (instanceName.length()) | |||
dafilesrvPath.appendf("[@name=\"%s\"]", instanceName.str()); | |||
IPropertyTree *daFileSrv = env->queryPropTree(dafilesrvPath); | |||
Owned<IPropertyTree> _dafileSrv; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: This might be cleaner on line 412, reducing the scope of the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but other variable is a pointer, so needed for the lifetime of the object.
@@ -432,21 +446,16 @@ int main(int argc,char **argv) | |||
Owned<IPropertyTree> _dafileSrvInstance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: similar comment for this variable as above.
Automated Smoketest: ❌ Unit tests result:
Regression test result:
|
Also add logging for Row Service SSL setup.
Signed-off-by: Jake Smith jake.smith@lexisnexisrisk.com
Type of change:
Checklist:
Testing: