Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-22145 Add ReactJS to ECL Watch framework #12870

Merged
merged 1 commit into from
Aug 15, 2019
Merged

HPCC-22145 Add ReactJS to ECL Watch framework #12870

merged 1 commit into from
Aug 15, 2019

Conversation

miguelvazq
Copy link

@miguelvazq miguelvazq commented Aug 13, 2019 •
edited
Loading

Fixes: HPCC-22145

Signed-off-by: Miguel Vazquez miguel.vazquez@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-22145
Jira not updated (pull request already registered)

@miguelvazq miguelvazq force-pushed the FixReactTSIssues branch 2 times, most recently from 954a069 to 445ce66 Compare August 13, 2019 01:41
@miguelvazq
Copy link
Author

@GordonSmith Please review after fixing some TS issues.

@miguelvazq miguelvazq force-pushed the FixReactTSIssues branch 3 times, most recently from 0842daf to 06faf4b Compare August 13, 2019 13:22
@miguelvazq miguelvazq changed the title HPCC-22145 Add reactjs to ECL Watch framework HPCC-22145 Add ReactJS to ECL Watch framework Aug 13, 2019
@miguelvazq miguelvazq force-pushed the FixReactTSIssues branch 13 times, most recently from 95d293a to d8882e8 Compare August 14, 2019 15:15
HPCC-22145 Add ReactJS to ECL Watch framework
09eaef5 
Fixes: HPCC-22145

Signed-off-by: Miguel Vazquez <miguel.vazquez@lexisnexisrisk.com>
@miguelvazq
Copy link
Author

@GordonSmith This should be good now. After various testing.

miguelvazq
miguelvazq commented Aug 14, 2019
View reviewed changes
esp/src/package.json
@@ -26,7 +26,8 @@
"dev-start": "ws",
"dev-link": "rimraf ./node_modules/@hpcc-js && mklink /J .\\node_modules\\@hpcc-js ..\\..\\..\\hpcc-js\\packages",
"dev-unlink": "rimraf ./node_modules/@hpcc-js && npm install",
"test": "run-s lint"
"test": "run-s lint",
"postinstall": "rimraf ./node_modules/**/preact/dist/preact.d.ts"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did remove the preact directory under @types

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-327.28.3.el7.x86_64)
GCC:gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Sha: 09eaef5
Build: success
Build: success
Install HPCC Platform
HPCC Start: OK
HPCC Stop: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
39 sec (00:00:39) 249 sec (00:04:09) 0 sec (00:00:00) 93 sec (00:01:33) 26 sec (00:00:26) 0 sec (00:00:00) 14 sec (00:00:14) 421 sec (00:07:01)

@GordonSmith GordonSmith self-requested a review August 15, 2019 13:40
@GordonSmith
Copy link
Member

Code looks fine.
@richardkchapman this is just a POC for developing React Components and isn't actually in any pages (yet).

@richardkchapman richardkchapman merged commit 230f836 into hpcc-systems:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miguelvazq @hpcc-jirabot @HPCCSmoketest @GordonSmith @richardkchapman