-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-25462 Improve esdl service namespace generation #14679
HPCC-25462 Improve esdl service namespace generation #14679
Conversation
https://track.hpccsystems.com/browse/HPCC-25462 |
- Enable method-specific namespaces in the ESDL definition. - Enable variable substitution in the ESDL definition's namespace values. - Enable service- and method-specific namespaces in the ESDL binding. - Enable variable substituion in the ESDL binding's namespace values. - Give the ESDL binding precedence over the ESDL definition. - Allow the ESDL binding to defer to the EspService configuration. Signed-off-by: Tim Klemm <tim.klemm@lexisnexisrisk.com>
6327654
to
0321fa2
Compare
Automated Smoketest: ❌ Unit tests result:
Regression test result:
HPCC Stop: OK
|
if (params->hasProp(key)) | ||
{ | ||
if (!tmp.isEmpty()) | ||
tmp.append(','); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These assumptions about how optional values are formatted in the namespace show why a scripted version of namespace configuration would potentially be valuable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment, we shouldn't do anything like this now, but technically I think you could include parameters in the variable name with the current replace variables implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timothyklemm looks fine.
Signed-off-by: Tim Klemm tim.klemm@lexisnexisrisk.com
Type of change:
Checklist:
Smoketest:
Testing: