Roxie filecache release #2103
Merged
Roxie filecache release #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roxie generating file names for index parts other than the top-level key incorrectly. This would lead to some confusion, and possibly additional copying of files, but no other ill effect as far as I can see. Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
The code for checking and comparing filestamps when deciding if Roxie's cached copy of a file was up to date seems to have been lost in the big refactoring of package files, meaning that file mismatches would only be detected when the size changed. This had a few unfortunate effects: 1. Index changes are likely to be only detected by slaves but not by server nodes. This leads to 'partially suspended' queries which were are not giving helpful error messages. 2. If data is refreshed on thor, Roxie might continue to read a previously cached version of the data, even if Roxie was restarted. See gh-2096. This is not a complete fix for all the issues there, since Roxie is still falsely reporting that two versions of a data file are required at the same time when all queries using the previous version have been unloaded. Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Roxie was nto clearing the local file cache when the last query
that referenced a file was released. This means that it was not
possible to load a new query that referenced an updated version
of a file without restarting roxie
Fixes gh-2096.
Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
|
Can the file cache be destroyed before the file objects? If so they need to setCache(NULL) on any items it knows about |
|
filecache is destroyed late in the closedown process via MODULE_EXIT, so I don't think so. But I suppose might be cleaner if they did. |
Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
ghalliday
added a commit
that referenced
this pull request
Apr 16, 2012
Roxie filecache release Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.