Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-10174 Add Remote Dali Option #5002

Merged
merged 1 commit into from
Oct 16, 2013

Conversation

miguelvazq
Copy link

Add the ability for a remote dali to be entered
upon publish of a workunit.

Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com

@hpcc-jirabot
Copy link

Jira updated

@miguelvazq
Copy link
Author

This has been tested by @cloLN and myself with success. @GordonSmith please review.

@@ -183,6 +183,7 @@ define([
lang.mixin(request, {
StateOrig: this.State,
JobnameOrig: this.Jobname,
RemoteDali: this.RemoteDali,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line should be here as "RemoteDali" is never part of the WU itself Its part of the published query?

Add the ability for a remote dali to be entered
upon publish of a workunit.

Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
@miguelvazq
Copy link
Author

@GordonSmith Please re-verify

@GordonSmith
Copy link
Member

Looks good.

richardkchapman added a commit that referenced this pull request Oct 16, 2013
HPCC-10174 Add Remote Dali Option

Reviewed-By: Gordon Smith <gordon.smith@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman richardkchapman merged commit 63d878f into hpcc-systems:master Oct 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants