HPCC-13534 Improve support for distributed streaming functions #7316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
|
https://track.hpccsystems.com/browse/HPCC-13534 |
|
@richardkchapman please review |
|
Automated Smoketest Build: success
HPCC Stop: OK |
| case no_externalcall: | ||
| if (isDistributedFunctionCall(expr)) | ||
| return true; | ||
| //MORE: check for streamed inputs. |
There was a problem hiding this comment.
Is there a JIRA open for the additional work?
There was a problem hiding this comment.
Yes - See HPCC-12921 and child tasks.
|
One minor question. @jakesmith are you still happy with the thor change? |
|
Yep, looks good. |
richardkchapman
added a commit
that referenced
this pull request
May 27, 2015
HPCC-13534 Improve support for distributed streaming functions Reviewed-By: Jake Smith <jake.smith@lexisnexis.com> Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.