Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-13886 Use merge sort in preference to stable quick sort #7541

Merged
merged 1 commit into from
Jul 17, 2015
Merged

HPCC-13886 Use merge sort in preference to stable quick sort #7541

merged 1 commit into from
Jul 17, 2015

Conversation

ghalliday
Copy link
Member

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-13866
Jira updated

@ghalliday
Copy link
Member Author

@richardkchapman @jakesmith please review.

@ghalliday
Copy link
Member Author

Richard - I should default the spilling sort in roxie as well, but I'll need to rebase once my other change is merged to do that. (Or have a separate commit.)

@richardkchapman
Copy link
Member

I think you may have the wrong jira number on this?

@ghalliday
Copy link
Member Author

Dyslexia or something... I'll fix.

@ghalliday
HPCC-13886 Use merge sort in preference to stable quick sort
5741ecb 
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@ghalliday ghalliday changed the title HPCC-13866 Use merge sort in preference to stable quick sort HPCC-13886 Use merge sort in preference to stable quick sort Jul 9, 2015
@ghalliday ghalliday closed this Jul 9, 2015
@ghalliday ghalliday reopened this Jul 9, 2015
@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-13886
Jira updated

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest Build: success
HPCC Start: OK
HPCC Stop: OK

@ghalliday
Copy link
Member Author

@AttilaVamos any ideas why smoketest failed like this? (master builds for me)

@ghalliday
Copy link
Member Author

Added some timing information to the jira

@HPCCSmoketest
Copy link
Contributor

That was a test-smoketest on a new HW and it is failed somehow. "Build failure" comment deleted.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest Build: success
HPCC Start: OK
HPCC Stop: OK

@ghalliday
Copy link
Member Author

@richardkchapman back for you to review.

richardkchapman added a commit that referenced this pull request Jul 17, 2015
@richardkchapman
Merge pull request #7541 from ghalliday/issue13866
97d4f50 
HPCC-13886 Use merge sort in preference to stable quick sort

Reviewed By: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman richardkchapman merged commit 97d4f50 into hpcc-systems:master Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghalliday @hpcc-jirabot @richardkchapman @HPCCSmoketest