HPCC-14243 Add method to retrieve cluster group #7805
Conversation
|
https://track.hpccsystems.com/browse/HPCC-14243 |
|
@ghalliday - please review |
|
Automated Smoketest Build: success |
Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
jakesmith
force-pushed
the
hpcc-14243
branch
from
b5184fe
to
1ccc38d
Compare
|
Automated Smoketest Build: success |
| @@ -9131,6 +9158,9 @@ class CInitGroups | |||
|
|
|||
| bool loadMachineMap() | |||
| { | |||
| if (machinesLoaded) | |||
There was a problem hiding this comment.
Does this need protecting with a critical section?
There was a problem hiding this comment.
don't think so, CInitGroups is a utility class used and not thread safe in general and not expected to be.
|
@jakesmith a few questions. It looks a relatively safe change. |
Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
|
@ghalliday - please see replies and minor changes. |
|
Automated Smoketest Build: success |
HPCC-14243 Add method to retrieve cluster group Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Signed-off-by: Jake Smith jake.smith@lexisnexis.com