Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-14827 Update cassandra cpp driver to latest version 2.2.2 #8158

Merged

Conversation

richardkchapman
Copy link
Member

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman
Copy link
Member Author

@rpastrana Please review

@hpcc-jirabot
Copy link

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest Build: success
Install hpccsystems-platform-community-with-plugins_5.5.0-closedown1.el6.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK

@rpastrana
Copy link
Member

commit number seems correct: datastax/cpp-driver@b4bb435

@richardkchapman
Copy link
Member Author

Do you have a cass3 installation you can test against?

@rpastrana
Copy link
Member

I do, I'll run Easy cassandra against it

@rpastrana
Copy link
Member

most of easycassandra works, but datatypes represented as "set of" generated errors:

Error: System error: 0: cassandra: While binding parameter list1: Invalid value type (processing query
INSERT INTO tbl1 (name, value, boolval, r8, r4,d,ddd,u1,u2,a,set1,list1,map1) values (?,?,?,?,?,?,?,?,?,?,?,?,?);)

also:
testCassandraSet : Error: Error: 0: cassandra: type mismatch - scalar expected (0, 0), 0,
testCassandraList: Error: Error: 0: cassandra: type mismatch - scalar expected (0, 0), 0,
testCassandraMap: Error: System error: 0: Graph[1], cassandra: type mismatch - row expected (0, 0), 0,
and I could not recreate, but I did get a seg fault in one case:
Error: SIG: Segmentation fault(11), accessing 0000000000000000, IP=00007F8CAB0F70CE (0, 0), 1000,

@richardkchapman
Copy link
Member Author

It's quite likely there is a very similar bug to the one I just fixed in Python in the Cassandra driver.

If you can come with some test ECL illustrating it please open a new Jira

Newest Cassandra driver is stricter about checking collection types, so we
need to be a bit more careful about guessing whether an ECL set corresponds to
a Cassandra list or set column.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman
Copy link
Member Author

@rpastrana Please retest

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest Build: success
Install hpccsystems-platform-community-with-plugins_5.5.0-closedown1.el6.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK

@rpastrana
Copy link
Member

@richardkchapman
confirmed the following data types were mapped successfully:
SET OF STRING set1,
SET OF INTEGER4 list1,
LINKCOUNTED DICTIONARY(maprec) map1{linkcounted};

where maprec := RECORD
string fromVal => string toVal
END;

@richardkchapman
Copy link
Member Author

@ghalliday Please review/merge

ghalliday added a commit that referenced this pull request Feb 3, 2016
HPCC-14827 Update cassandra cpp driver to latest version 2.2.2

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
@ghalliday ghalliday merged commit 39511f0 into hpcc-systems:candidate-5.6.0 Feb 3, 2016
@richardkchapman richardkchapman deleted the cassandra-latest branch July 23, 2017 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants