Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-15425 Improve the reported position for invalid string characters #8543

Merged
merged 2 commits into from
Apr 27, 2016
Merged

HPCC-15425 Improve the reported position for invalid string characters #8543

merged 2 commits into from
Apr 27, 2016

Conversation

ghalliday
Copy link
Member

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

@ghalliday
HPCC-15425 Improve the reported position for invalid string characters
1a46911 
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@ghalliday
Copy link
Member Author

@shamser please review.
Richard I'm not concerned if this slips to 6.0.2

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-15425
Jira updated

@richardkchapman
Copy link
Member

It will, unless Shamser can review it now...

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest
Sha: 1a46911
Build: success
Install hpccsystems-platform-community_6.0.0-rc2.el6.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK

@shamser
Copy link
Contributor

shamser commented Apr 22, 2016

@ghalliday @richardkchapman I'm reviewing this now

@shamser
Copy link
Contributor

shamser commented Apr 22, 2016

@ghalliday Just one minor: is it worth commoning up the error handling code within 1710-1850 into a function call? The changes looks good.

@ghalliday
HPCC-15425 Common up some code following review
0d1dd5c 
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@ghalliday
Copy link
Member Author

@shamser I've commoned up some of the code, I'm not sure it is worth doing any more.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest
Sha: 0d1dd5c
Build: success
Install hpccsystems-platform-community_6.0.0-rc2.el6.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK

@richardkchapman
Copy link
Member

Should probably retarget for 6.0.2

@shamser
Copy link
Contributor

shamser commented Apr 27, 2016

@ghalliday Reviewed..looks good.

@richardkchapman richardkchapman merged commit 88462e1 into hpcc-systems:candidate-6.0.0 Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ghalliday @hpcc-jirabot @richardkchapman @HPCCSmoketest @shamser