Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-15755 DOCS:Correction to ECL SEQUENTIAL example #8905

Merged
merged 1 commit into from
Jul 29, 2016

Conversation

g-pan
Copy link
Member

@g-pan g-pan commented Jul 18, 2016

FIX HPCC-15755 DOCS:Correction to ECL SEQUENTIAL example
Corrected the code example in the ECL Lang Ref. for Sequential.

Signed-off-by: G Panagiotatos greg.panagiotatos@lexisnexis.com
@RichardTaylorHPCC please review

@RichardTaylorHPCC
Copy link
Contributor

I'd suggest removing the word "attributes" and replacing it with "definitions" (since you're changing the doc anyway) AND this same code example is in the PARALLEL doc, so it also needs to be fixed there

@RichardTaylorHPCC
Copy link
Contributor

These changes look good to me, although the PARALLEL discussion should point out that it doesn't force parallel execution but only allows it -- whether the actions are actually executed in parallel is up to the compiler/code generator

//by naming these actions, they become inactive
definitions
//that only execute when the definition names are called as
deinitions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@ghalliday
Copy link
Member

@g-pan some comments. Please squash commits as well.

FIX HPCC-15755 DOCS:Correction to ECL SEQUENTIAL example
Corrected the code example in the ECL Lang Ref. for Sequential.

Signed-off-by: G Panagiotatos <greg.panagiotatos@lexisnexis.com>
@HPCCSmoketest
Copy link
Contributor

Automated Smoketest
Sha: 648f951
Build: success
Install hpccsystems-platform-documentation_6.0.0-continuous0.el6.x86_64.rpm
HPCC Start: OK
Unittest result: total:81 passed:81 failed:0

HPCC Stop: OK
HPCC Uninstall: OK

@ghalliday ghalliday merged commit 417c893 into hpcc-systems:candidate-6.0.x Jul 29, 2016
@ghalliday
Copy link
Member

@g-pan g-pan deleted the H15755-ECLRParens branch May 30, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants