HPCC-16105 Fileservices checkExternalFileRights() incorrect check #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fileservices.cpp, method checkExternalFileRights accepts 2 flags indicating it should test for read, and one for write. The "if" statement presumes that only one of these can be true. Additionally, the "extpath" variable is never set, so the code never checks the specified file. This PR sets the path variable correctly, and checks for both read and write perms independently. Signed-off-by: Russ Whitehead <william.whitehead@lexisnexis.com>
|
https://track.hpccsystems.com/browse/HPCC-16105 |
|
@rpastrana Please review |
| @@ -2147,7 +2147,7 @@ FILESERVICES_API char * FILESERVICES_CALL fsfResolveHostName(const char *hostna | |||
|
|
|||
| static void checkExternalFileRights(ICodeContext *ctx, CDfsLogicalFileName &lfn, bool rd,bool wr) | |||
| { | |||
| StringAttr extpath; | |||
| StringAttr extpath(lfn.get()); | |||
There was a problem hiding this comment.
Do we need to introduce this var?
Could we use lfn.get() directlty in lines 2157, 2160, and 2165?
|
@RussWhitehead one minor comment in line. Also, it looks like this changes behavior, you might want to make sure ops knows this change is coming. |
|
@rpastrana Please rereview |
|
@RussWhitehead looks fine. |
|
@richardkchapman Please merge and close |
|
Automated Smoketest HPCC Stop: OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fileservices.cpp, method checkExternalFileRights accepts 2 flags indicating
it should test for read, and one for write. The "if" statement presumes that
only one of these can be true. Additionally, the "extpath" variable is never
set, so the code never checks the specified file. This PR sets the path
variable correctly, and checks for both read and write perms independently.
Signed-off-by: Russ Whitehead william.whitehead@lexisnexis.com