HPCC-14453 Preflight upgrade #9165

miguelvazq · 2016-09-23T22:12:49Z

Add pre flight submission form into new ECL Watch.

Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com

miguelvazq · 2016-09-23T22:12:58Z

@GordonSmith Please review.

hpcc-jirabot · 2016-09-23T22:13:01Z

https://track.hpccsystems.com/browse/HPCC-14453
Jira updated

GordonSmith · 2016-09-26T12:59:49Z

esp/src/eclwatch/PreflightDetailsWidget.js

+            return retVal;
+        },
+
+        getColumns: function (params) {


Should this be called "setColumns" or "setGridColumns"?

GordonSmith · 2016-09-26T13:05:12Z

esp/src/eclwatch/PreflightDetailsWidget.js

+                    var clean = finalColumns[index].replace(/([~!@#$%^&*()_+=`{}\[\]\|\\:;'<>,.\/? ])+/g, '').replace(/^(-)+|(-)+$/g,'');
+                    if (clean === 'Condition') {
+                        lang.mixin(dynamicColumns, {
+                            [clean] : {


What does this syntax do (I have not seen it before)?

This creates dynamic properties with the value from clean which in turn is 'Condition' 'State' 'RoxieCluster'

I didn't know you could do that with this syntax!

GordonSmith · 2016-09-26T13:05:24Z

esp/src/eclwatch/PreflightDetailsWidget.js

+            if (params) {
+                var finalColumns = params.Columns.Item;
+                for (index in finalColumns) {
+                    var clean = finalColumns[index].replace(/([~!@#$%^&*()_+=`{}\[\]\|\\:;'<>,.\/? ])+/g, '').replace(/^(-)+|(-)+$/g,'');


Is this removing HTML formatting?

Since the response returns "Column Name" I am removing any spaces and or special characters in it so that they come back like so: "ColumnName"

GordonSmith · 2016-09-26T13:05:39Z

esp/src/eclwatch/PreflightDetailsWidget.js

+                                }
+                            }
+                        });
+                    } if (clean === 'State') {


The "if" should be on a new line.

GordonSmith · 2016-09-26T13:10:30Z

esp/src/eclwatch/TopologyWidget.js

+                            WsMachine.GetMachineInfo ({
+                                request: {
+                                    [MachineInformationClean]: filter[MachineInformationClean],
+                                    [MachineInformationCount]: 1000,


Is this syntax correct?

I verified with @wangkx this count seems to increase based on selections and is subjective.

GordonSmith · 2016-09-26T13:10:39Z

esp/src/eclwatch/TopologyWidget.js

+                        WsMachine.GetTargetClusterInfo ({
+                            request: {
+                                [TargetClustersClean]: filter[TargetClustersClean],
+                                [TargetClusterCount]: 1000,


Is this syntax correct?

I verified with @wangkx this count seems to increase based on selections and is subjective.

GordonSmith · 2016-09-26T13:13:01Z

esp/src/eclwatch/TopologyWidget.js

+        },
+
+        createLabelAndElement: function (id, label, element, placeholder, value) {
+            var context = this;


should declare var control; here and then assign values to it in the switch statement

GordonSmith · 2016-09-26T13:15:33Z

Some questions.

miguelvazq · 2016-09-26T14:01:43Z

@GordonSmith updated.

richardkchapman · 2016-09-28T10:03:54Z

@miguelvazq Needs rebasing for a clean merge

miguelvazq · 2016-09-28T14:24:20Z

@richardkchapman rebased.

GordonSmith · 2016-09-28T14:00:08Z

plugins/cassandra/cpp-driver

@@ -1 +1 @@
-Subproject commit 468db35af8875930d424395808ddc9523c57c6f2
+Subproject commit d7bbad34db39a51f209c6fadd07c9ec3a0bb86b7


Should not be in this PR

GordonSmith · 2016-09-28T14:01:47Z

esp/src/eclwatch/css/hpcc.css

+
+table.miniSelect span {  
+     width:20px;
+}


Is this for an edit in place control?

This is for the selects that are smaller in nature such as "%" and or "MB"

GordonSmith · 2016-09-28T14:04:52Z

esp/src/eclwatch/TopologyWidget.js

+            var control = element;
+            switch (element) {
+                case "CheckBox":
+                    var control = new CheckBox ({


var control should be declared outside of the switch for clarity.

GordonSmith · 2016-09-28T14:04:55Z

esp/src/eclwatch/TopologyWidget.js

+                    });
+                break;
+                case "TextBox":
+                    var control = new ValidationTextBox ({


var control should be declared outside of the switch for clarity.

GordonSmith · 2016-09-28T14:05:00Z

esp/src/eclwatch/TopologyWidget.js

+                    });
+                break;
+                case "Select":
+                    var control = new Select ({


var control should be declared outside of the switch for clarity.

GordonSmith · 2016-09-28T14:05:04Z

esp/src/eclwatch/TopologyWidget.js

+                    });
+                break;
+                case "SelectMini":
+                    var control = new Select ({


var control should be declared outside of the switch for clarity.

GordonSmith · 2016-09-28T14:05:57Z

esp/src/eclwatch/TopologyWidget.js

+                    style: "vertical-align:middle;padding:2px 0 2px 5px;"
+                })
+            )
+            control.placeAt(this.id + id);


control is used outside of swicth - so var control should be declared before the switch statement, in case none of the branches are called.

Add pre flight submission form into new ECL Watch. Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>

miguelvazq · 2016-09-28T16:13:37Z

@GordonSmith changes made after latest comments

HPCCSmoketest · 2016-09-28T16:32:36Z

Automated Smoketest
Sha: 37283ae
Build: success
Install hpccsystems-platform-community_6.1.0-trunk0.el6.x86_64.rpm
HPCC Start: OK
Unittest result: total:83 passed:83 failed:0

HPCC Stop: OK
HPCC Uninstall: OK

richardkchapman · 2016-09-29T06:36:33Z

@GordonSmith Please re-review/approve

GordonSmith · 2016-09-29T07:18:41Z

Good to go.

GordonSmith requested changes Sep 26, 2016

View reviewed changes

miguelvazq force-pushed the PreflightUpgrade branch from b316a16 to 52dd2a3 Compare September 26, 2016 14:01

miguelvazq force-pushed the PreflightUpgrade branch from 52dd2a3 to 684916f Compare September 28, 2016 14:24

GordonSmith requested changes Sep 28, 2016

View reviewed changes

HPCC-14453 Preflight upgrade

37283ae

Add pre flight submission form into new ECL Watch. Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>

miguelvazq force-pushed the PreflightUpgrade branch from 684916f to 37283ae Compare September 28, 2016 16:12

GordonSmith approved these changes Sep 29, 2016

View reviewed changes

richardkchapman merged commit a0d0054 into hpcc-systems:master Sep 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HPCC-14453 Preflight upgrade #9165

HPCC-14453 Preflight upgrade #9165

miguelvazq commented Sep 23, 2016

miguelvazq commented Sep 23, 2016

hpcc-jirabot commented Sep 23, 2016

GordonSmith Sep 26, 2016

GordonSmith Sep 26, 2016

miguelvazq Sep 26, 2016

GordonSmith Sep 26, 2016

GordonSmith Sep 26, 2016

miguelvazq Sep 26, 2016

GordonSmith Sep 26, 2016

GordonSmith Sep 26, 2016

miguelvazq Sep 26, 2016

GordonSmith Sep 26, 2016

miguelvazq Sep 26, 2016

GordonSmith Sep 26, 2016 •

edited

Loading

GordonSmith commented Sep 26, 2016

miguelvazq commented Sep 26, 2016

richardkchapman commented Sep 28, 2016

miguelvazq commented Sep 28, 2016

GordonSmith Sep 28, 2016

GordonSmith Sep 28, 2016

miguelvazq Sep 28, 2016 •

edited

Loading

GordonSmith Sep 28, 2016

GordonSmith Sep 28, 2016

GordonSmith Sep 28, 2016

GordonSmith Sep 28, 2016

GordonSmith Sep 28, 2016

miguelvazq commented Sep 28, 2016

HPCCSmoketest commented Sep 28, 2016

richardkchapman commented Sep 29, 2016

GordonSmith commented Sep 29, 2016

		@@ -1 +1 @@
		Subproject commit 468db35af8875930d424395808ddc9523c57c6f2
		Subproject commit d7bbad34db39a51f209c6fadd07c9ec3a0bb86b7

HPCC-14453 Preflight upgrade #9165

HPCC-14453 Preflight upgrade #9165

Conversation

miguelvazq commented Sep 23, 2016

miguelvazq commented Sep 23, 2016

hpcc-jirabot commented Sep 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GordonSmith Sep 26, 2016 • edited Loading

Choose a reason for hiding this comment

GordonSmith commented Sep 26, 2016

miguelvazq commented Sep 26, 2016

richardkchapman commented Sep 28, 2016

miguelvazq commented Sep 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miguelvazq Sep 28, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miguelvazq commented Sep 28, 2016

HPCCSmoketest commented Sep 28, 2016

richardkchapman commented Sep 29, 2016

GordonSmith commented Sep 29, 2016

GordonSmith Sep 26, 2016 •

edited

Loading

miguelvazq Sep 28, 2016 •

edited

Loading