HPCC-16661 Added libhiredis submodule #9372
Conversation
Signed-off-by: Michael Gardner <michael.gardner@lexisnexis.com>
|
https://track.hpccsystems.com/browse/HPCC-16661 |
|
@xwang2713 @richardkchapman please see https://track.hpccsystems.com/browse/HPCC-16661 for discussion |
|
I've tested this build on centos 6 (no native hiredis package installed) and ubuntu 16.04 (has native hiredis package installed.) Links correctly to our supplied version. |
| @@ -43,3 +43,6 @@ | |||
| [submodule "libcouchbase"] | |||
| path = plugins/couchbase/libcouchbase | |||
| url = https://github.com/hpcc-systems/libcouchbase.git | |||
| [submodule "plugins/redis/hiredis"] | |||
| path = plugins/redis/hiredis | |||
| url = https://github.com/redis/hiredis.git | |||
There was a problem hiding this comment.
As with the other submodules, we need to clone this to ensure that it continues to exist
|
@richardkchapman Just updated the URL. Going to do a quick test build to make sure all is well. |
Michael-Gardner
force-pushed
the
HPCC-16661
branch
from
722ba1a
to
5858561
Compare
|
@richardkchapman tested on centos 6 and ubuntu 16.04. Worked as before (not that I was expecting anything different, the commit it points to is the same despite the fork). I went ahead and squashed the commits. |
|
Automated Smoketest
Install hpccsystems-platform-community_6.2.0-rc5.el7.x86_64.rpm Unittest result:
HPCC Stop: OK |
Michael-Gardner
force-pushed
the
HPCC-16661
branch
from
5858561
to
a7b2383
Compare
Signed-off-by: Michael Gardner michael.gardner@lexisnexis.com