HPCC-17286 options are not passed to parameterless embed functions

[richardkchapman]

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browers
  • The component(s) render as expected

Testing:

Added test case to regression suite

[hpcc-jirabot]

https://track.hpccsystems.com/browse/HPCC-17286
Jira updated

[richardkchapman]

@ghalliday Please review/merge

[HPCCSmoketest]

Automated Smoketest: ✅
Sha: 4bd7eb8
Build: success
ECL Watch: Rebuilding Site

errors	warnings	build time
0	65	91.169 seconds

Install hpccsystems-platform-community_6.3.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	93	93	0	0	0
wutoolTest(Dali)	19	19	0	0	0
wutoolTest(Cassandra)	19	16	3	0	0

Regression test result:

setup	hthor	thor	roxie
roxie_echo	Pass	Pass	Pass
roxie_keepwhitespace	Pass	Pass	Pass
setup	Pass	Pass	Pass
setup_fetch	Pass	Pass	Pass
setupdict	Pass	Pass	Pass
setupsearchindex	Pass	Pass	Pass
setupsq	Pass	Pass	Pass
setupwordindex	Pass	Pass	Pass
setupxml	Pass	Pass	Pass

test	hthor	thor	roxie
embedpy2	Pass	Excl.	Pass

HPCC Stop: OK
HPCC Uninstall: OK