Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-17457 Add instructions for debugging java services #9971

Merged
merged 1 commit into from
May 18, 2017
Merged

HPCC-17457 Add instructions for debugging java services #9971

merged 1 commit into from
May 18, 2017

Conversation

mayx
Copy link
Member

@mayx mayx commented May 10, 2017 •
edited
Loading

  • Add a commented-out line to environment.conf for java remote debugging
  • Add debugging instructions in ReadMeFirst.txt file of esdl examples

Signed-off-by: mayx yanrui.ma@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browers
    • The component(s) render as expected

Testing:

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-17457
Jira updated

@mayx
Copy link
Member Author

mayx commented May 10, 2017

@afishbeck Hi Tony please review the change.

afishbeck
afishbeck requested changes May 17, 2017
View reviewed changes
Copy link
Member

@afishbeck afishbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayx minor wording comment

initfiles/examples/EsdlExample/ReadMeFirst.txt Outdated
jvmoptions=-XX:-UsePerfData -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=2000
And comment out the original jvmoptions line:
#jvmoptions=-XX:-UsePerfData
From eclipse for java, create a new debug configuration for remote java application, under connect tab, select your esdl java service project, select standard socket attach connection type, fill in the host and port. The port is what you specify in the jvmoptions inside environment.conf, which is 2000 in our example above. Click the Debug button and off you go.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"specified" or even better, "The port should match what you've specified".

@mayx
HPCC-17457 Add instructions for debugging java services
3002bc5 
- Add a commented-out line to environment.conf for java remote debugging
- Add debugging instructions in ReadMeFirst.txt file of esdl examples

Signed-off-by: mayx <yanrui.ma@lexisnexisrisk.com>
@mayx
Copy link
Member Author

mayx commented May 17, 2017

@afishbeck Wording updated as suggested, please review again...

afishbeck
afishbeck approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@afishbeck afishbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayx looks good

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
Sha: 3002bc5
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 93.126 seconds

Install hpccsystems-platform-community_6.3.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 93 93 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 10 10 0
setup (thor) 10 10 0
setup (roxie) 10 10 0
test (hthor) 728 728 0
test (thor) 622 622 0
test (roxie) 749 749 0

HPCC Stop: OK
HPCC Uninstall: OK

@richardkchapman richardkchapman merged commit c98417f into hpcc-systems:candidate-6.4.0 May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afishbeck afishbeck afishbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mayx @hpcc-jirabot @HPCCSmoketest @afishbeck @richardkchapman