Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending "carriage return" breaks logging #59

Closed
dajose opened this issue Jun 16, 2017 · 1 comment
Closed

Sending "carriage return" breaks logging #59

dajose opened this issue Jun 16, 2017 · 1 comment

Comments

@dajose
Copy link
Contributor

dajose commented Jun 16, 2017

I have an old telnet shell that needs a \r at the end of the line for the command to actually execute.

This causes the connection logger to not log the command

>>> telnet_shell.send_command('/off {}\r'.format(port))
', matches=['bla> '], newline=True, timeout=None)

This can be solved by making the logger do repr(command) when logging, but not sure if it is the correct approach... What do you guys think?

@ocelotl ocelotl changed the title Sending "carriage return" breaks loggin Sending "carriage return" breaks logging Jun 16, 2017
@ocelotl ocelotl removed their assignment Oct 22, 2019
@carlos-jenkins
Copy link
Contributor

No longer seen. Re-open if found again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants