Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log field and helpers for StatisticsService #998

Closed
6 tasks done
Greenscreen23 opened this issue May 19, 2023 · 0 comments · Fixed by #1004
Closed
6 tasks done

Add log field and helpers for StatisticsService #998

Greenscreen23 opened this issue May 19, 2023 · 0 comments · Fixed by #1004
Assignees
Labels
frontend Issues mainly related to the frontend

Comments

@Greenscreen23
Copy link
Contributor

Greenscreen23 commented May 19, 2023

  • A log entry contains time, tags for everything that might be relevant to the event, and some description of the event. This description should be configurable. One cheap option is to start with either plain text descriptions or a map of plain text description fragments stiched together in the frontend.
  • Tags are objects containing a display name, a category (patient, patient category, simulatedRegion, ...) and a specifier custom to this category. All these fields are strings. Maybe also a color. Maybe not. The specific tags are not part of this issue.
  • The state contains an optional and unvalidated field for an array of log entries.
  • There are helpers for use in reducers that depend on the state and add log entries.
  • If the array is there, the helpers add entries, otherwise they do nothing.
  • In particular, the helpers must not calculate and discard the log entry but only compute it if required.
@Greenscreen23 Greenscreen23 added the frontend Issues mainly related to the frontend label May 19, 2023
@Greenscreen23 Greenscreen23 added this to the G: Analysis of a MANV milestone May 19, 2023
@Greenscreen23 Greenscreen23 self-assigned this May 19, 2023
@Greenscreen23 Greenscreen23 linked a pull request May 22, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues mainly related to the frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant