Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch image is a poor example #3

Open
fulldecent opened this issue Jan 14, 2016 · 1 comment
Open

Fetch image is a poor example #3

fulldecent opened this issue Jan 14, 2016 · 1 comment

Comments

@fulldecent
Copy link
Contributor

In https://github.com/hpique/Articles/blob/master/Swift/Style%20guide%20for%20functions%20with%20closure%20parameters/Style%20guide%20for%20functions%20with%20closure%20parameters.md

Fetching an image is a poor example of an action which you would react to neither upon success nor failure. A better example may be posting an update or sending a ping.

Also, the example seems contrived when there is a check for success == nil && failure == nil for posting an image. A real world application would never do this.

@fulldecent
Copy link
Contributor Author

To be clear, are you still accepting contributions to this project?? If so would a PR that fixes this be in scope to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant