Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truecaser Test dependency on norvig.com/big.txt #49

Closed
DavidHarrison opened this issue Apr 21, 2019 · 3 comments
Closed

Truecaser Test dependency on norvig.com/big.txt #49

DavidHarrison opened this issue Apr 21, 2019 · 3 comments

Comments

@DavidHarrison
Copy link

norvig.com is currently down which is causing the tests in sacremoses/test/test_truecaser.py to fail if big.txt has not already been downloaded. I'm wondering if there is another source of the file that might be more reliable or whether it could be included in the repository (e.g. with Git LFS).

@alvations
Copy link
Contributor

Thanks @DavidHarrison for the suggestion! I wanted to keep the testing light so I left out the file rather than putting it in the repo with LFS.

I'll try to look out for better way(s) to test file in, file out functions. That'll be helpful for #37 too.

@alvations
Copy link
Contributor

@alvations
Copy link
Contributor

Resolved c.f. #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants