Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh install and bug when u try to delete user on jfa #13

Closed
Killianbe opened this issue Nov 2, 2020 · 10 comments
Closed

Fresh install and bug when u try to delete user on jfa #13

Killianbe opened this issue Nov 2, 2020 · 10 comments

Comments

@Killianbe
Copy link
Contributor

Hi
It's always me ^^
Fresh install to unstable

when i want delete user in jfa i press delete and nothing working

error :

2020/11/02 18:14:38 [Recovery] 2020/11/02 - 18:14:38 panic recovered:
interface conversion: interface {} is nil, not string
/usr/local/go/src/runtime/iface.go:261 (0x40af6e)
	panicdottypeE: panic(&TypeAssertionError{iface, have, want, ""})
/opt/build/api.go:210 (0xb6f8d8)
/opt/build/api.go:417 (0xb7264c)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/context.go:161 (0x990e7a)
/opt/build/auth.go:92 (0xb7c9f7)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/context.go:161 (0x990e7a)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/recovery.go:83 (0x9a4b44)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/context.go:161 (0x990e7a)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/logger.go:241 (0x9a3c44)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/context.go:161 (0x990e7a)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/gin.go:409 (0x99ae99)
/go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/gin.go:367 (0x99a58c)
/usr/local/go/src/net/http/server.go:2843 (0x719fc2)
	serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
/usr/local/go/src/net/http/server.go:1925 (0x7156cc)
	(*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
/usr/local/go/src/runtime/asm_amd64.s:1374 (0x46fcc0)
	goexit: BYTE	$0x90	// NOP) 

2nde : user's email not appear in jfa (work for ombi)

3th : user account in jfa not auto update when we create user, i need to restart docker for synch

if u need something i'm here, i can help u on discord if u want tester :)

@hrfee
Copy link
Owner

hrfee commented Nov 2, 2020

Issue 1: This is only happening because of issue 2.

Issue 2: Based on the failure in issue 1, I think that jfa-go isn't able to write to /config/emails.json. I'll add some better logging so it actually gives us an error instead of failing silently.

Issue 3: This happens because jfa-go will cache the user list for 30 minutes unless it does something that would change it itself, and so creating/deleting a user within Jellyfin won't affect the cache instantly. I can add an option to change the cache expiry so you can set it to something smaller.

@Killianbe
Copy link
Contributor Author

So, what can i do ?

@hrfee
Copy link
Owner

hrfee commented Nov 2, 2020

Ok, i've published a new build which has a cache_timeout option under the [jellyfin] section that you can set to a lower value if you want. It also should output errors when trying to write to emails.json. Give it a run and try to edit an email address or create an account, and looks for errors in the program output.

@Killianbe
Copy link
Contributor Author

add email manualy work, and write to email.json work too. But create with invite don't write email on json file

@hrfee
Copy link
Owner

hrfee commented Nov 3, 2020

Are you using the normal form.html or your custom version?

@Killianbe
Copy link
Contributor Author

i use normal form, with json file for lang

@hrfee
Copy link
Owner

hrfee commented Nov 3, 2020

Do you have password resets disabled? I only just noticed that emails are stored only if its enabled. Since there are other reasons to store email addresses now (e.g account deletion notifications), i'll change it.

@Killianbe
Copy link
Contributor Author

Yes i don't use password reset! but i want use it! just i don't know where i need to point the password reset file for jellyfin

@hrfee
Copy link
Owner

hrfee commented Nov 4, 2020

I assume you use docker for Jellyfin also. The directory you have mounted to /config in the jellyfin container needs to be mounted to /jf in jfa-go, e.g
Jellyfin:
docker create --name jellyfin -v /path/to/config:/config jellyfin/jellyfin
jfa-go:
docker create --name jfa-go -v /path/to/config:/jf hrfee/jfa-go

@Killianbe
Copy link
Contributor Author

ok thx i close :)
Nice job man !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants