Merge pull request #18743 from hrydgard/retroachievements-match-libretro

Change when we call rc_client_do_frame to something that matches libretro
hrydgard · Jan 23, 2024 · 3fae8dd · 3fae8dd
2 parents f3c2d10 + ec411e0
commit 3fae8dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Core/HLE/sceDisplay.cpp b/Core/HLE/sceDisplay.cpp
@@ -499,9 +499,6 @@ static void DoFrameIdleTiming() {
 void hleEnterVblank(u64 userdata, int cyclesLate) {
 	int vbCount = userdata;
 
-	// This should be a good place to do it. Should happen once per vblank. Here or in leave? Not sure it matters much.
-	Achievements::FrameUpdate();
-
 	VERBOSE_LOG(SCEDISPLAY, "Enter VBlank %i", vbCount);
 
 	DisplayFireVblankStart();

diff --git a/UI/EmuScreen.cpp b/UI/EmuScreen.cpp
@@ -1432,6 +1432,9 @@ ScreenRenderFlags EmuScreen::render(ScreenRenderMode mode) {
 		}
 
 		PSP_EndHostFrame();
+
+		// This place rougly matches how libretro handles it (after retro_frame).
+		Achievements::FrameUpdate();
 	}