Permalink
Browse files

Merge pull request #10058 from bentley/master

Use W^X on OpenBSD.
  • Loading branch information...
unknownbrackets committed Nov 6, 2017
2 parents 0b68130 + 9fc355e commit de459e6a1db1efb027ceb8a6bde36fb8dc7b4d23
Showing with 2 additions and 2 deletions.
  1. +2 −2 Common/MemoryUtil.cpp
View
@@ -284,9 +284,9 @@ void FreeAlignedMemory(void* ptr) {
}
bool PlatformIsWXExclusive() {
// Only iOS really needs this mode currently. Even without block linking, still should be much faster than IR JIT.
// Needed on platforms that disable W^X pages for security. Even without block linking, still should be much faster than IR JIT.
// This might also come in useful for UWP (Universal Windows Platform) if I'm understanding things correctly.
#if defined(IOS) || PPSSPP_PLATFORM(UWP)
#if defined(IOS) || PPSSPP_PLATFORM(UWP) || defined(__OpenBSD__)
return true;
#else
// Returning true here lets you test the W^X path on Windows and other non-W^X platforms.

2 comments on commit de459e6

@Sunil2735

This comment has been minimized.

Show comment
Hide comment
@Sunil2735

Sunil2735 Nov 6, 2017

I really appreciate your work. I have been using it on my laptop and on my android Lenovo p2. From last few releases while installing it on Android device it's giving an error saying.. This package seems to be corrupted. Can you please fix this :)

Sunil2735 replied Nov 6, 2017

I really appreciate your work. I have been using it on my laptop and on my android Lenovo p2. From last few releases while installing it on Android device it's giving an error saying.. This package seems to be corrupted. Can you please fix this :)

@Sunil2735

This comment has been minimized.

Show comment
Hide comment
@Sunil2735

Sunil2735 Nov 6, 2017

I was able to sign the app with third party app worked for me.:)

Sunil2735 replied Nov 6, 2017

I was able to sign the app with third party app worked for me.:)

Please sign in to comment.