Skip to content

Commit

Permalink
Merge pull request #10058 from bentley/master
Browse files Browse the repository at this point in the history 
Use W^X on OpenBSD.
  • Loading branch information
@unknownbrackets
unknownbrackets committed Nov 6, 2017
2 parents 0b68130 + 9fc355e commit de459e6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Common/MemoryUtil.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,9 @@ void FreeAlignedMemory(void* ptr) {
}

bool PlatformIsWXExclusive() {
// Only iOS really needs this mode currently. Even without block linking, still should be much faster than IR JIT.
// Needed on platforms that disable W^X pages for security. Even without block linking, still should be much faster than IR JIT.
// This might also come in useful for UWP (Universal Windows Platform) if I'm understanding things correctly.
#if defined(IOS) || PPSSPP_PLATFORM(UWP)
#if defined(IOS) || PPSSPP_PLATFORM(UWP) || defined(__OpenBSD__)
return true;
#else
// Returning true here lets you test the W^X path on Windows and other non-W^X platforms.
Expand Down

2 comments on commit de459e6

@Sunil2735
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate your work. I have been using it on my laptop and on my android Lenovo p2. From last few releases while installing it on Android device it's giving an error saying.. This package seems to be corrupted. Can you please fix this :)

@Sunil2735
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to sign the app with third party app worked for me.:)

Please sign in to comment.