Skip to content

Commit

Permalink
Remove snprintf compatibility hacks for MSVC versions before 2015
Browse files Browse the repository at this point in the history
  • Loading branch information
hrydgard committed Aug 31, 2017
1 parent 42cb559 commit ff3d799
Show file tree
Hide file tree
Showing 13 changed files with 6 additions and 73 deletions.
4 changes: 0 additions & 4 deletions Common/CommonFuncs.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,8 @@

#pragma once

#include "base/compat.h"
#include "CommonTypes.h"

template <bool> struct CompileTimeAssert;
template<> struct CompileTimeAssert<true> {};

#ifndef ARRAY_SIZE
#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
#endif
Expand Down
2 changes: 0 additions & 2 deletions Core/HLE/sceKernelMemory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
#include <vector>
#include <map>

#include "base/compat.h"

#include "Common/ChunkFile.h"
#include "Core/HLE/HLE.h"
#include "Core/HLE/FunctionWrappers.h"
Expand Down
1 change: 0 additions & 1 deletion UI/DevScreens.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#include <algorithm>

#include "base/compat.h"
#include "gfx_es2/gpu_features.h"
#include "i18n/i18n.h"
#include "ui/ui_context.h"
Expand Down
4 changes: 1 addition & 3 deletions UWP/NativeUWP/NativeUWP.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,6 @@
<ClInclude Include="..\..\ext\native\base\basictypes.h" />
<ClInclude Include="..\..\ext\native\base\buffer.h" />
<ClInclude Include="..\..\ext\native\base\colorutil.h" />
<ClInclude Include="..\..\ext\native\base\compat.h" />
<ClInclude Include="..\..\ext\native\base\display.h" />
<ClInclude Include="..\..\ext\native\base\linked_ptr.h" />
<ClInclude Include="..\..\ext\native\base\logging.h" />
Expand Down Expand Up @@ -394,7 +393,6 @@
<ClCompile Include="..\..\ext\native\base\backtrace.cpp" />
<ClCompile Include="..\..\ext\native\base\buffer.cpp" />
<ClCompile Include="..\..\ext\native\base\colorutil.cpp" />
<ClCompile Include="..\..\ext\native\base\compat.cpp" />
<ClCompile Include="..\..\ext\native\base\display.cpp" />
<ClCompile Include="..\..\ext\native\base\logging.cpp" />
<ClCompile Include="..\..\ext\native\base\stringutil.cpp" />
Expand Down Expand Up @@ -1317,4 +1315,4 @@
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
</ImportGroup>
</Project>
</Project>
8 changes: 1 addition & 7 deletions UWP/NativeUWP/NativeUWP.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@
<ClCompile Include="..\..\ext\native\base\colorutil.cpp">
<Filter>base</Filter>
</ClCompile>
<ClCompile Include="..\..\ext\native\base\compat.cpp">
<Filter>base</Filter>
</ClCompile>
<ClCompile Include="..\..\ext\native\base\display.cpp">
<Filter>base</Filter>
</ClCompile>
Expand Down Expand Up @@ -476,9 +473,6 @@
<ClInclude Include="..\..\ext\native\base\colorutil.h">
<Filter>base</Filter>
</ClInclude>
<ClInclude Include="..\..\ext\native\base\compat.h">
<Filter>base</Filter>
</ClInclude>
<ClInclude Include="..\..\ext\native\base\display.h">
<Filter>base</Filter>
</ClInclude>
Expand Down Expand Up @@ -726,4 +720,4 @@
<Filter>gfx</Filter>
</ClInclude>
</ItemGroup>
</Project>
</Project>
4 changes: 1 addition & 3 deletions Windows/Debugger/BreakpointWindow.cpp
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
#include <stdio.h>
#include <cstdio>

#include "base/compat.h"
#include "util/text/utf8.h"

#include "BreakpointWindow.h"
#include "../resource.h"


BreakpointWindow* BreakpointWindow::bp;

INT_PTR CALLBACK BreakpointWindow::dlgFunc(HWND hwnd, UINT iMsg, WPARAM wParam, LPARAM lParam)
Expand Down
1 change: 0 additions & 1 deletion ext/native/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ LOCAL_ARM_MODE := arm
LOCAL_SRC_FILES :=\
base/backtrace.cpp \
base/buffer.cpp \
base/compat.cpp \
base/display.cpp \
base/timeutil.cpp \
base/colorutil.cpp \
Expand Down
28 changes: 0 additions & 28 deletions ext/native/base/compat.cpp

This file was deleted.

11 changes: 0 additions & 11 deletions ext/native/base/compat.h

This file was deleted.

1 change: 0 additions & 1 deletion ext/native/base/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include "base/arch.h"
#include "base/backtrace.h"
#include "base/compat.h"

// Simple wrapper around Android's logging interface that also allows other
// implementations, and also some misc utilities.
Expand Down
3 changes: 1 addition & 2 deletions ext/native/math/lin/matrix4x4.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#include "math/lin/matrix4x4.h"

#include <stdio.h>
#include <cstdio>

#include "base/compat.h"
#include "math/lin/vec3.h"
#include "math/lin/quat.h"
#include "math/fast/fast_matrix.h"
Expand Down
4 changes: 1 addition & 3 deletions ext/native/native.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@
<ClInclude Include="base\basictypes.h" />
<ClInclude Include="base\buffer.h" />
<ClInclude Include="base\colorutil.h" />
<ClInclude Include="base\compat.h" />
<ClInclude Include="base\display.h" />
<ClInclude Include="base\logging.h" />
<ClInclude Include="base\NativeApp.h" />
Expand Down Expand Up @@ -295,7 +294,6 @@
<ClCompile Include="base\backtrace.cpp" />
<ClCompile Include="base\buffer.cpp" />
<ClCompile Include="base\colorutil.cpp" />
<ClCompile Include="base\compat.cpp" />
<ClCompile Include="base\display.cpp" />
<ClCompile Include="base\logging.cpp" />
<ClCompile Include="base\PCMain.cpp">
Expand Down Expand Up @@ -758,4 +756,4 @@
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
</ImportGroup>
</Project>
</Project>
8 changes: 1 addition & 7 deletions ext/native/native.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,6 @@
<ClInclude Include="thread\executor.h">
<Filter>thread</Filter>
</ClInclude>
<ClInclude Include="base\compat.h">
<Filter>base</Filter>
</ClInclude>
<ClInclude Include="gfx\gl_common.h">
<Filter>gfx</Filter>
</ClInclude>
Expand Down Expand Up @@ -736,9 +733,6 @@
<ClCompile Include="thread\executor.cpp">
<Filter>thread</Filter>
</ClCompile>
<ClCompile Include="base\compat.cpp">
<Filter>base</Filter>
</ClCompile>
<ClCompile Include="base\PCMain.cpp">
<Filter>base</Filter>
</ClCompile>
Expand Down Expand Up @@ -859,4 +853,4 @@
<UniqueIdentifier>{06c6305a-a646-485b-85b9-645a24dd6553}</UniqueIdentifier>
</Filter>
</ItemGroup>
</Project>
</Project>

0 comments on commit ff3d799

Please sign in to comment.