Skip to content

Commit

Permalink
Remove now-redundant check, add a TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
hrydgard committed May 5, 2023
1 parent 640c4fe commit ff72203
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions GPU/GPUCommon.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1000,6 +1000,7 @@ void GPUCommon::DoExecuteCall(u32 target) {

if (currentList->stackptr == ARRAY_SIZE(currentList->stack)) {
ERROR_LOG(G3D, "CALL: Stack full!");
// TODO: UpdateState(GPUSTATE_ERROR) ?
} else {
auto &stackEntry = currentList->stack[currentList->stackptr++];
stackEntry.pc = retval;
Expand Down
4 changes: 1 addition & 3 deletions GPU/GPUCommonHW.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -803,9 +803,7 @@ void GPUCommonHW::FastRunLoop(DisplayList &list) {
} else {
uint64_t flags = info.flags;
if (flags & FLAG_FLUSHBEFOREONCHANGE) {
if (drawEngineCommon_->GetNumDrawCalls()) {
drawEngineCommon_->DispatchFlush();
}
drawEngineCommon_->DispatchFlush();
}
gstate.cmdmem[cmd] = op;
if (flags & (FLAG_EXECUTE | FLAG_EXECUTEONCHANGE)) {
Expand Down

0 comments on commit ff72203

Please sign in to comment.