Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sceKernelExitThread #13298

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Fix sceKernelExitThread #13298

merged 3 commits into from
Aug 18, 2020

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Aug 17, 2020

@sum2012 sum2012 changed the title Kernel patch Fix sceKernelExitThread Aug 17, 2020
@hrydgard
Copy link
Owner

Nice find!

We already have the error codes declared in sceKernel.h though, no need to redeclare them. Please change to use:

SCE_KERNEL_ERROR_CAN_NOT_WAIT
SCE_KERNEL_ERROR_ILLEGAL_ARGUMENT

Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Oops, should've read @hrydgard's reply first.

-[Unknown]

Core/HLE/sceKernelThread.h Outdated Show resolved Hide resolved
Core/HLE/sceKernelThread.cpp Outdated Show resolved Hide resolved
@hrydgard hrydgard added this to the v1.11.0 milestone Aug 17, 2020
@sum2012
Copy link
Collaborator Author

sum2012 commented Aug 17, 2020

@hrydgard @unknownbrackets done

@hrydgard
Copy link
Owner

Thanks, looks good! Will merge when the build is green.

@unknownbrackets unknownbrackets merged commit 6e4e9a2 into hrydgard:master Aug 18, 2020
@sum2012 sum2012 deleted the kernel_patch branch August 18, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants