Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the "Test Analogs" screen with a new screen that lets you directly try the settings. #14596

Merged
merged 7 commits into from
Jul 9, 2021

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jul 9, 2021

image
image
Also thinking about renaming some of those settings and there are some further possible UX improvements, but let's get this in first.

@hrydgard hrydgard added the Input/Controller Input and controller issues label Jul 9, 2021
@hrydgard hrydgard added this to the v1.12.0 milestone Jul 9, 2021
@hrydgard hrydgard merged commit 5bd9e93 into master Jul 9, 2021
@hrydgard hrydgard deleted the analog-setup-screen branch July 9, 2021 17:30
Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is a much better way to visualize the settings.

-[Unknown]

ConfigSetting("AnalogSensitivity", &g_Config.fAnalogSensitivity, 1.0f, true, true),
ConfigSetting("AnalogIsCircular", &g_Config.bAnalogIsCircular, true, true, true),
ConfigSetting("AnalogSensitivity", &g_Config.fAnalogSensitivity, 1.1f, true, true),
ConfigSetting("AnalogIsCircular", &g_Config.bAnalogIsCircular, false , true, true),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it circular on most platforms? Won't this give a lot of people diagonal problems?

-[Unknown]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has a circular-ish range on many platforms, but the circular transform used here is a bit extreme and feels weird testing it with the new visualization. Generally it works better to just increase sensitivity (scale) and clamp to a square.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, got it.

-[Unknown]

void Draw(UIContext &dc) override;
std::string DescribeText() const override { return ""; }
std::string DescribeText() const override { return "Analog Stick View"; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a title_, so any description should include the title, and possibly values. I was trying to use this semantically as an accessibility tree. Using it as a developer name for the control is more the purpose of DescribeLog().

I'd previously intentionally made it blank because the associated text was separate from this graphical representation, so this view had on separate and useful textual meaning. Not sure if that's still true.

I realize it's not really exposed in a useful way to any accessibility tree at this point, and you probably wouldn't search it, but just wanted to explain the purpose of the method as I'd considered it.

-[Unknown]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, this was just a driveby change and I didn't reflect on the real purpose. Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants