Radiant Mythology 2 and 3 have incorrect music/voices

[vsub]

Before when attrac was not part of ppsspp,ppsspp would randomly crash and I'll get the Send\Don't send dialog with at3plusdecoder.dll for the reason(doesn't happen with 0.9.1-452 or maybe it happens extremely rarely)

When I try something after 0.9.5(including),the music randomly disappear and I'll randomly get this is the console
cSoundMusic E[ME]: HLE\sceAtrac.cpp:602 avcodec_decode_audio4: Error decoding audio -1163346256

The only way to restore the music is by restarting ppsspp and load normal save(not save state)

[papel]

According to the log, the problem is in sceAtracGetBufferInfoForResetting.
http://forums.ppsspp.org/showthread.php?tid=1807&pid=50687#pid50687

Was it working in v0.9.5-331?
Was it broken in v0.9.5-333?

Please test these two versions:
http://buildbot.orphis.net/ppsspp/

[vsub]

I also tried 0.9.5 before posting but the music will also randomly disappear.
Tried:
0.9.1-839 - few battles and changing party members at the arena...it didn't crash
0.9.1-863 - crashed after the first battle when I tried to change party members
0.9.5-331 - music disappear after the first battle in the arena when I was changing party members
Also the same thing appear too
cSoundMusic E[ME]: HLE\sceAtrac.cpp:608 avcodec_decode_audio4: Error decoding audio -1094995529

Don't know if it's a bug but when I'm changing party members(exit the menu after I change the party members),ppsspp is either freezing for few seconds or doing some really heavy things that will reduce the speed to 1 or 2fps for few seconds

[papel]

And how is it in v0.9.5-333 or in the most recent autobuilt version?

[vsub]

Same thing on 333 and 549.
All music requiring attrac simply stop playing...only sound effects are working

[vsub]

Will this be useful?
I create two save states(for the English patched and the original image)that are at the end of battle right before the sound problem is triggered.

Btw when the problem appear,in Disassembly in threads StreamDataReader appear with N/A for PC address and if you set a break point at 08AA8334,it will pause the emulation every time before voice or music is executed.

[papel]

It seems v0.9.1-839 was the last working version.
A solution is reverting the changes explained in #4473 (comment), but it breaks Ys Seven.

[vsub]

Break how...I clear Ys 7 twice by using 0.9.1-452 and it crashed only once which would mean that something between 452 and 839 breaks Ys 7 and its fixing it after 839

[papel]

The problem in Ys7 only happens on x64 in three specific areas (#2391).

[Sendayu]

Heya I was wondering,may I know what is the status of this problem?
I tested radiant Myth 2 and 3 and it seem this problem still happen despite the other game Ys7 has been fixed.
I tested this game with version v0.9.6-584-ga0a9ad4

[vsub]

Still the same on 0.9.8-453 x86(it happens only after battle)
The music will randomly stop and the only way to fix it,is to restart the game

[raven02]

I'm trying to reproduce it , is it missing music after the 1st battle below ?

[vsub]

It happens randomly.
I just start the game,go to that area(where you are now)and play battles.
At one point,the background music of the area will disappear and from then on,either only the area background music will stay disabled or the music everywhere.

When you start a new game,there is no place without music(if I remember correctly),so if you don't have right now(on that image),that means you already have the problem.
PS.The problem is saved in the save state too,so even if you restart the game,if you load that state,you will not have music again

[raven02]

I tried 3 times and 2 times okay with music after battle.

Not too sure if it related to this ?

51:21:253 ModuleDispat W[KERNEL]: HLE\sceKernelThread.cpp:2817 sceKernelReleaseWaitThread(): Refusing to wake HLE-delayed thread, right thing to do?
51:21:253 user_main W[HLE]: HLE\HLE.cpp:83 Someone else woke up HLE-blocked thread?

[vsub]

I just tried new game now,and after the first battle,the music disappear.
Sometimes,you have to play couple of battles to trigger the problem(also no idea if it will help,but try to enter the menus too)

[raven02]

Okay so did it work all time correct in some builds before ? or it is regression ?

[vsub]

Look at the first post...I've been trying many revs till now but the music always disappear

[raven02]

Alright .I just tried turn off JIT and tested 2 times from startung new game , it looks good with music after battle.Can you try from your side as well ?

[vsub]

Ok,I'll try new game and save a save state before every battle and when the problem appear after the battle,I'll create another state and post both of them.

Will that be useful?
Btw which one should I play...the original or the english patched(it happens on both)

[raven02]

May be checking original first .

[vsub]

Here,happen on my first try.
I also tried the same thing on 0.9.1-452 and the music didn't disappear after the first battle
Slot 1 - have music and disappear after the battle
Slot 2 - the music is not running anywhere(only sound effects)

This is for the original version(not patched)...24MB zip archive
http://www19.zippyshare.com/v/85683771/file.html

[raven02]

So with jit off , music works fine after battle?

[vsub]

Didn't tried with jit off(it's running a lot slower when it's disabled)...I'll try

[vsub]

It happens with Jit off and also with all settings reverted to default.
The strange thing is,it ALWAYS happens(at least here)after the first battle(restart ppsspp and start a new game)when I use 0.9.8-431 but it's ok with 0.9.1-452

[raven02]

I see. Then probably not related to JIT.

[vsub]

Anything else I should post or try to help finding the problem?

[raven02]

I pretty much sure it is StreadDataThread no doing it job again which produce the BGM

[vsub]

Still no change(0.9.8-1628)
The music disappear after the first battle :(

[u9510136]

0.9.9 & still have the same problem.
The music will disappear after several battle and never played until reset the game.

[daniel229]

Radiant Mythology 2 in this scene,BGM would be lost when sample>=1914975,Force atrac->currentSample = 0; in sceAtracResetPlayPosition() can avoid BGM lost.

[daniel229]

All the BGM of the dungeons are the same lost when sample>=1914975 in Radiant Mythology 2,Radiant Mythology 3 is about 1911000,but not test all the dungeons.So hack it as
if(sample >= 1911000) sample = 0; to avoid BGM lost.

[u9510136]

AH~thanks for help, and sorry that I actually haven't learned computer language

so can someone help and release a test build ??

[daniel229]

You can try it out,only windows build
https://drive.google.com/file/d/0BzGZGDfFE68zMWo5QXRQcFhqTjQ/edit?usp=sharing

[u9510136]

I have tried several dungeon (not all yet) and none of the BGM stopped temporarily.

thanks a lot !!

[unknownbrackets]

Fixed by #6935, yay.

-[Unknown]

[unknownbrackets]

Reportedly the music is still wrong, although at least it's there.

-[Unknown]

[daniel229]

just found that bug.some voice wrong at its biginning
https://www.youtube.com/watch?v=b-XuSWJahBo

[daniel229]

Radiant Mythology 2 also has the same bug.

[unknownbrackets]

Well, I think we can keep it to just this issue.

-[Unknown]

[daniel229]

Music stop since unknownbrackets@60378dd

16:50:501 cSoundMusic  I[ME]: HLE\sceAtrac.cpp:1436 sceAtracReleaseAtracID(1)
16:50:517 cSoundMusic  I[ME]: HLE\sceAtrac.cpp:1760 0=sceAtracSetDataAndGetID(08cb3040, 00020000)
16:50:517 cSoundMusic  W[ME]: HLE\sceAtrac.cpp:1652 This is an atrac3+ stereo audio
16:50:556 cSoundVoice  I[ME]: HLE\sceAtrac.cpp:1760 1=sceAtracSetDataAndGetID(08cdb080, 00002478)
16:50:556 cSoundVoice  W[ME]: HLE\sceAtrac.cpp:1650 This is an atrac3+ mono audio
16:50:658 cSoundVoice  I[ME]: HLE\sceAtrac.cpp:1436 sceAtracReleaseAtracID(1)
16:50:994 cSoundMusic  I[ME]: HLE\sceAtrac.cpp:1436 sceAtracReleaseAtracID(0)
16:51:042 cSoundMusic  I[ME]: HLE\sceAtrac.cpp:1760 0=sceAtracSetDataAndGetID(08cb3040, 00020000)
16:51:042 cSoundMusic  W[ME]: HLE\sceAtrac.cpp:1652 This is an atrac3+ stereo audio
16:51:043 cSoundMusic  I[ME]: HLE\sceAtrac.cpp:1157 0=sceAtracGetBufferInfoForResetting(0, 2096644, 09ffddd8)
16:51:044 user_main    I[SCEGE]: Common\FramebufferCommon.cpp:417 Creating FBO for 00155f80 : 128 x 128 x 3
16:51:045 cSoundMusic  I[ME]: HLE\sceAtrac.cpp:1506 0=sceAtracResetPlayPosition(0, 2096644, 131040, 0)
16:51:747 cSoundMusic  I[KERNEL]: HLE\sceKernelThread.cpp:1943 394=sceKernelCreateThread(StreamDataReader, 08a6f0b4, 00000014, 4096, 00000000, 0000000
0)
16:51:747 cSoundMusic  I[KERNEL]: HLE\sceKernelThread.cpp:2014 0=sceKernelStartThread(394, 16, 09ffddc8)
16:51:747 StreamDataRe I[KERNEL]: HLE\sceKernelThread.cpp:2066 sceKernelExitThread(1)
16:55:147 cSoundMusic  I[ME]: HW\MediaEngine.cpp:87 FF: Frame data doesn't match channel configuration!
16:55:147 cSoundMusic  E[ME]: HLE\sceAtrac.cpp:444 avcodec_decode_audio4: Error decoding audio -1094995529 / bebbb1b7
16:55:151 cSoundMusic  I[ME]: HLE\sceAtrac.cpp:1436 sceAtracReleaseAtracID(0)

[unknownbrackets]

If you revert the first two changes of 60378dd only, does it change it?

I'm guessing this is streaming. Maybe it's related to the remaining frame number, then, but not sure why that commit would've altered it...

-[Unknown]

[daniel229]

Yeah,it works..
Does not work.

[daniel229]

it seems it was broken before unknownbrackets@60378dd

[daniel229]

It seems it less happens in the old build.The new build often happen in 2,3 battles.
Get 1 music stop in 50 battles in v1.0.1-207-g79fc557
I don't get music stop in 50 battles in v1.0.1-170-g1f987ef and v1.0.1-52-g3773d25

[unknownbrackets]

Improved at all by #8189? Sorry for so many battles, I know how it can be testing something that doesn't always happen...

-[Unknown]

[daniel229]

Looks good,without music stop in 50 battles.

[unknownbrackets]

Awesome.

Are the voices still wrong at the beginning? Maybe we should create a separate bug for just that if it's all that left - it might have a separate cause, and there's lots of info here already.

-[Unknown]

[daniel229]

The voices is the same as #8156

[unknownbrackets]

Is the voice thing still happening or is that fixed now?

-[Unknown]

[daniel229]

Fixed.

[unknownbrackets]

Yay, this one's been a little bit of a journey. Feels good to hit the close button.

-[Unknown]