GLES: Allow dual src blend on newer Intel #10439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
reviewed
Dec 24, 2017
| // Don't use this extension on sub 3.0 OpenGL versions as it does not seem reliable | ||
| } else if (gl_extensions.gpuVendor == GPU_VENDOR_INTEL) { | ||
| // Also on Intel, see https://github.com/hrydgard/ppsspp/issues/10117 | ||
| // TODO: Remove entirely sometime reasonably far in driver years after 2015. |
There was a problem hiding this comment.
Interesting concept of "driver years" :)
|
It will take me a few days before I can test. |
|
Tested on IVB system with driver 10.18.10.4653 using God Eater Trial Version and it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10117. Compared versions from opengl.gpuinfo.org, to validate there weren't other affected ranges.
Also, since the driver was released in 2015, left a note to remove the code sometime reasonably after.
@pal1000 could you validate this enables it?
-[Unknown]